-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FW version display after FW update #13316
Update FW version display after FW update #13316
Conversation
@maloel can you help reviewing this PR? |
This PR will work as long as the user holds the context from which the device was created. E.g.:
This will not call This may be OK: if we can agree that, for the D457 notifications to work, the user has to keep holding the context, then the PR is acceptable. To make it so that the notification is sent to ALL contexts that may be listening, more extensive changes must be made: we need to take the invocation up to the level of the device-watcher and likely add an API to device_info. @Nir-Az please see if the above is acceptable or whether we want to make more extensive changes. |
I'm OK with that, |
Notice there's an error in the CI |
Tracked by LRS-686